Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tapcfg: read multiverse cache from cfg instead of using default #1297

Merged
merged 1 commit into from
Jan 13, 2025
Merged

tapcfg: read multiverse cache from cfg instead of using default #1297

merged 1 commit into from
Jan 13, 2025
+8 −1

Conversation

Roasbeef
Copy link
Member

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12756271445

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 17 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.01%) to 40.957%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tapcfg/server.go 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
tapgarden/planter.go 2 74.12%
asset/asset.go 2 80.95%
asset/mock.go 3 92.24%
universe/interface.go 10 52.81%
Totals Coverage Status
Change from base Build 12755845393: 0.01%
Covered Lines: 26421
Relevant Lines: 64509
💛 - Coveralls

@gijswijs gijswijs self-requested a review January 13, 2025 21:35
gijswijs
gijswijs approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@gijswijs gijswijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Just to check: with this change we only use DefaultMultiverseStoreConfig() in the context of tests

@Roasbeef
Copy link
Member Author

Just to check: with this change we only use DefaultMultiverseStoreConfig() in the context of tests

Correct. When we make the default config, we use a version of that that only makes the inner cache struct: https://github.com/lightninglabs/taproot-assets/blob/main/tapcfg/config.go#L437-L439

@Roasbeef Roasbeef merged commit e631a03 into main Jan 13, 2025
18 checks passed
@guggero guggero deleted the multiverse-cache-set branch January 14, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gijswijs gijswijs gijswijs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Roasbeef @coveralls @gijswijs