Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapdb: thread through enabled flag correctly #1296

Merged
merged 1 commit into from
Jan 13, 2025
Merged

tapdb: thread through enabled flag correctly #1296

merged 1 commit into from
Jan 13, 2025

Conversation

guggero
Copy link
Member

@guggero guggero commented Jan 13, 2025

Flag was forgotten to be threaded through, so cache never turned on outside of unit tests.

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚡

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12752782384

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.01%) to 40.958%

Files with Coverage Reduction New Missed Lines %
tapdb/multiverse_cache.go 2 72.78%
tapchannel/aux_leaf_signer.go 2 43.08%
tapdb/addrs.go 2 75.09%
asset/asset.go 2 80.95%
Totals Coverage Status
Change from base Build 12737232835: 0.01%
Covered Lines: 26414
Relevant Lines: 64491

💛 - Coveralls

@Roasbeef Roasbeef merged commit ec80946 into main Jan 13, 2025
18 checks passed
@guggero guggero deleted the fix-sync-cache branch January 13, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants