Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset: change all-zero hash to empty leaf #1263

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

guggero
Copy link
Member

@guggero guggero commented Dec 19, 2024

Changes the behavior of the group key reveal v1.

@guggero guggero requested review from Roasbeef and ffranr December 19, 2024 16:29
@guggero guggero force-pushed the group-key-reveal-change branch from ed0f363 to e91cf2c Compare December 19, 2024 16:37
@coveralls
Copy link

coveralls commented Dec 19, 2024

Pull Request Test Coverage Report for Build 12416915320

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 37 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.009%) to 40.969%

Files with Coverage Reduction New Missed Lines %
tappsbt/create.go 2 53.22%
tapgarden/planter.go 2 74.12%
tapchannel/aux_leaf_signer.go 3 43.43%
tapgarden/caretaker.go 4 68.87%
commitment/tap.go 4 83.64%
asset/mock.go 4 92.09%
asset/asset.go 4 80.81%
tapdb/multiverse.go 6 68.21%
universe/interface.go 8 53.68%
Totals Coverage Status
Change from base Build 12416163407: 0.009%
Covered Lines: 26415
Relevant Lines: 64475

💛 - Coveralls

@GeorgeTsagk
Copy link
Member

the legacy group key reveal is V0, therefore there's nothing breaking with this PR, correct?

Copy link
Contributor

@ffranr ffranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Now the user can always specify all leaf scripts.

@ffranr
Copy link
Contributor

ffranr commented Dec 19, 2024

the legacy group key reveal is V0, therefore there's nothing breaking with this PR, correct?

Yes, exactly.

@guggero guggero merged commit 24c802a into main Dec 19, 2024
18 checks passed
@guggero guggero deleted the group-key-reveal-change branch December 19, 2024 17:07
@dstadulis dstadulis added this to the v0.5 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants