Update release notes template re timestamps #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release notes template has been updated to improve the paragraph on timestamps. It now correctly specifies both ots artifacts and how to use them to verify the timestamps of the manifest and its signature. Secondly, the template now explains how the timestamp of the _git tag_ can be verified by using the OpenTimestamps git wrapper.
gijswijs
commented
Dec 4, 2024
Pull Request Test Coverage Report for Build 12164840984Details
💛 - Coveralls |
guggero
approved these changes
Dec 5, 2024
| @@ -87,14 +87,17 @@ jobs: | |||
|
|
|||
| ## Verifying the Release Timestamp | |||
|
|
|||
| From this new version onwards, in addition time-stamping the _git tag_ with [OpenTimestamps](https://opentimestamps.org/), we'll also now timestamp the manifest file along with its signature. Two new files are now included along with the rest of our release artifacts: ` manifest-roasbeef-${{ env.RELEASE_VERSION }}.txt.asc.ots`. | |||
| In addition to time-stamping the _git tag_ with [OpenTimestamps](https://opentimestamps.org/), we also timestamp the manifest file along with its signature. Two files are included in our release artifacts: `manifest-roasbeef-${{ env.RELEASE_VERSION }}.sig.ots` and `manifest-${{ env.RELEASE_VERSION }}.txt.ots`. | |||
There was a problem hiding this comment.
Do we actually do that today though? Or is the idea that we start doing it for future releases?
There was a problem hiding this comment.
What I understood from @Roasbeef he actually does this, since he uses the wrapper and consequently tags created by him are timestamped automatically.
There was a problem hiding this comment.
Yeah I always do this manually once I sign.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release notes template has been updated to improve the paragraph on
timestamps. It now correctly specifies both ots artifacts and how to use
them to verify the timestamps of the manifest and its signature.
Secondly, the template now explains how the timestamp of the git tag
can be verified by using the OpenTimestamps git wrapper.