Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support user-generated RFQ on tchrpc.SendPayment #1224

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

GeorgeTsagk
Copy link
Member

Closes #1215

@GeorgeTsagk GeorgeTsagk self-assigned this Nov 28, 2024
@coveralls
Copy link

coveralls commented Nov 28, 2024

Pull Request Test Coverage Report for Build 12156853306

Details

  • 0 of 69 (0.0%) changed or added relevant lines in 1 file are covered.
  • 30 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.07%) to 40.826%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcserver.go 0 69 0.0%
Files with Coverage Reduction New Missed Lines %
tappsbt/create.go 2 53.22%
tapchannel/aux_leaf_signer.go 3 43.43%
commitment/tap.go 3 84.7%
universe/interface.go 4 51.95%
tapdb/universe.go 4 80.91%
asset/mock.go 6 91.73%
asset/asset.go 8 80.79%
Totals Coverage Status
Change from base Build 12141057283: -0.07%
Covered Lines: 25782
Relevant Lines: 63151

💛 - Coveralls

rpcserver.go Outdated Show resolved Hide resolved
taprpc/tapchannelrpc/tapchannel.proto Outdated Show resolved Hide resolved
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Simple enough approach. Have two suggestions though, otherwise looks good, thank you 🎉

taprpc/tapchannelrpc/tapchannel.proto Outdated Show resolved Hide resolved
rpcserver.go Show resolved Hide resolved
@GeorgeTsagk GeorgeTsagk force-pushed the sendpayment-manual-rfq branch from f2557d3 to 5d0569e Compare December 2, 2024 10:59
@GeorgeTsagk GeorgeTsagk requested review from ffranr and guggero December 2, 2024 11:02
Copy link
Contributor

@ffranr ffranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Oli has a good point and that we should pass in the RFQ quote ID and not the SCID. I think that would be clearer, see comment thread.

@GeorgeTsagk GeorgeTsagk force-pushed the sendpayment-manual-rfq branch 2 times, most recently from 46c24bb to c339cd5 Compare December 2, 2024 14:09
@GeorgeTsagk GeorgeTsagk requested a review from ffranr December 2, 2024 14:09
@GeorgeTsagk GeorgeTsagk force-pushed the sendpayment-manual-rfq branch from c339cd5 to b7427dc Compare December 2, 2024 15:27
taprpc/tapchannelrpc/tapchannel.proto Show resolved Hide resolved
rpcserver.go Outdated Show resolved Hide resolved
rpcserver.go Outdated Show resolved Hide resolved
rpcserver.go Outdated Show resolved Hide resolved
@GeorgeTsagk GeorgeTsagk force-pushed the sendpayment-manual-rfq branch 2 times, most recently from 89ed3fa to a49cded Compare December 3, 2024 13:24
@GeorgeTsagk GeorgeTsagk requested a review from guggero December 3, 2024 14:37
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

rpcserver.go Outdated Show resolved Hide resolved
rpcserver.go Outdated Show resolved Hide resolved
rpcserver.go Outdated Show resolved Hide resolved
rpcserver.go Outdated Show resolved Hide resolved
@GeorgeTsagk GeorgeTsagk force-pushed the sendpayment-manual-rfq branch from a49cded to 9da1d71 Compare December 4, 2024 09:32
@GeorgeTsagk GeorgeTsagk requested a review from ffranr December 4, 2024 09:33
@ffranr ffranr added this pull request to the merge queue Dec 4, 2024
Merged via the queue into lightninglabs:main with commit 77fa6dd Dec 4, 2024
18 checks passed
@dstadulis dstadulis added this to the v0.5 (v0.4.2 rename) milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[feature]: Allow specifying a custom RFQ scid on tchrpc.SendPayment
5 participants