-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support user-generated RFQ on tchrpc.SendPayment
#1224
Conversation
Pull Request Test Coverage Report for Build 12156853306Details
💛 - Coveralls |
5976aac
to
f2557d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Simple enough approach. Have two suggestions though, otherwise looks good, thank you 🎉
f2557d3
to
5d0569e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Oli has a good point and that we should pass in the RFQ quote ID and not the SCID. I think that would be clearer, see comment thread.
46c24bb
to
c339cd5
Compare
c339cd5
to
b7427dc
Compare
89ed3fa
to
a49cded
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
a49cded
to
9da1d71
Compare
Closes #1215