Updated ListAssetRequest to include additional filter options

[itsrachelfish]

Resolves #876

This PR adds new filter options to the ListAssets RPC call.

• The ListAssetRequest proto definition was updated to include the new filter options.
• The fetchRpcAssets function was refactored to accept a AssetQueryFilters argument so that separate arguments don't need to be added for each filter option.
• The assets store constraintsToDbFilter function was updated to use the new filter options.
• And the assets.sql file was updated to include a new maxAmount option.

[coveralls]

Pull Request Test Coverage Report for Build 12439004519

Details

• 17 of 86 (19.77%) changed or added relevant lines in 3 files are covered.
• 20 unchanged lines in 5 files lost coverage.
• Overall coverage decreased (-0.03%) to 40.935%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tapdb/assets_store.go	16	33	48.48%
rpcserver.go	0	52	0.0%

Files with Coverage Reduction	New Missed Lines	%
asset/asset.go	2	81.08%
asset/mock.go	3	92.68%
tapgarden/caretaker.go	4	68.5%
universe/interface.go	5	50.65%
tapchannel/aux_invoice_manager.go	6	83.25%

Totals
Change from base Build 12417405641:	-0.03%
Covered Lines:	26423
Relevant Lines:	64548

---

💛 - Coveralls

[GeorgeTsagk]

looking good!
it's in the right direction 💯

[GeorgeTsagk]

lots of improvements! ⬆️
I have one comment on the types of filters

We'll also need that unit test coverage ✔️

[GeorgeTsagk]

this whole block is not needed, you can just leave query.MaxAmt initialized to default values (Valid: false)

[GeorgeTsagk]

missing godocs (see MinAnchorHeight above)

[GeorgeTsagk]

we can't really have user-facing arguments that reference database IDs

the ScriptKeyID is the DB identifier for a script key and there's no possible way a user could (...easily) get their hands on one of them in order to filter the assets

Instead we could have *AssetQueryFilters expose scriptKey []byte and anchorOutpoint []byte filters, which the user can easily acquire, then on this point in the code we could map these values to the unique db ID that the underlying layer requires for filtering (that is QueryAssetFilters struct)

[GeorgeTsagk]

if you add some tests with the current way things work, you'll see that when you'll try to query a specific script key you'll have trouble finding the ID to filter by

[GeorgeTsagk]

you should add some unit test coverage in tapdb to test the behavior of AssetStore.FetchAllAssets

[Roasbeef]

I think this function can help resolve the issue w.r.t getting the internal ID, you can just specify all the normal bytes (script key, anchor point, etc):

taproot-assets/tapdb/assets_store.go

Lines 904 to 935 in ec84760

	// specificAssetFilter maps the given asset parameters to the set of filters
	// we use in the SQL queries.
	func (a *AssetStore) specificAssetFilter(id asset.ID, anchorPoint wire.OutPoint,
	groupKey *asset.GroupKey,
	scriptKey *asset.ScriptKey) (QueryAssetFilters, error) {
	anchorPointBytes, err := encodeOutpoint(anchorPoint)
	if err != nil {
	return QueryAssetFilters{}, fmt.Errorf("unable to encode "+
	"outpoint: %w", err)
	}
	filter := QueryAssetFilters{
	AssetIDFilter: id[:],
	AnchorPoint: anchorPointBytes,
	Now: sql.NullTime{
	Time: a.clock.Now().UTC(),
	Valid: true,
	},
	}
	if groupKey != nil {
	key := groupKey.GroupPubKey
	filter.KeyGroupFilter = key.SerializeCompressed()
	}
	if scriptKey != nil {
	key := scriptKey.PubKey
	filter.TweakedScriptKey = key.SerializeCompressed()
	}
	return filter, nil
	}

[lightninglabs-deploy]

@itsrachelfish, remember to re-request review from reviewers when ready