More RFQ improvments #1197
Merged
More RFQ improvments #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Things left to think about:
|
Pull Request Test Coverage Report for Build 11913943259Details
💛 - Coveralls |
GeorgeTsagk
reviewed
Nov 19, 2024
Refactor SellOrder by replacing the fields "asset ID" and "asset group key" with a single "asset specifier" field for simplicity and consistency.
Currently, the `SellOrder.Peer` field must be specified, but in the future, the negotiator should be able to select the optimal peer automatically. This commit updates the interface to support this future functionality by making `SellOrder.Peer` an Option type. Note that this field was already a pointer.
This commit removes the `peer` argument from the methods queryBidFromPriceOracle and queryAskFromPriceOracle
Populate the expiry timestamp field in SellOrder and use type `time.Time`.
ffranr
force-pushed
the
rfq-improvments-20241115
branch
from
df78d25 to
0ef0264
Compare
guggero
reviewed
Nov 19, 2024
Refactor BuyAccept by replacing multiple fields with a single asset rate field using the new AssetRate type.
When handling a quote request accept message, the peer-provided price must be validated against our price oracle. This commit passes the peer-provided price as a hint to the oracle, offering additional context to improve decision-making.
Improve doc by relating these types to the wider lightning payment flow context.
Populate the expiry timestamp field in BuyOder and use type `time.Time`.
Improve doc by relating this type to the wider lightning payment flow context.
Refactor SellAccept by replacing multiple fields with a single asset rate field using the new AssetRate type.
Changed the `expiry` argument in `expiryWithinBounds` to be of type `time.Time` for improved type safety and clarity.
Set the converted `time.Time` to UTC when transforming from Unix time. This change promotes consistency and simplifies debugging.
Ensure the request message version check validates only a specific version number, rather than accepting any version greater than or equal to the latest message number.
ffranr
force-pushed
the
rfq-improvments-20241115
branch
from
0ef0264 to
abf47dc
Compare
guggero
approved these changes
Nov 19, 2024
Update the buy/sell classification logic for incoming requests to rely on the new transfer type field. When the requesting peer attempts to pay an invoice using a Tap asset, they are "selling" the Tap asset to the edge node. Conversely, when the requesting peer attempts to receive a Tap asset as payment to settle an invoice, they are "buying" the Tap asset from the edge node.
ffranr
force-pushed
the
rfq-improvments-20241115
branch
from
abf47dc to
a1d989d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve docs for:
SellOrder,SellRequest,BuyOrder,BuyRequest.Populate transfer type field in request.
Make use of
AssetRatetype.