scripts: use trap
to make sure old files always restored
#1187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we fix an issue I observed on my machine after updating many command line/dev utilities.
I observed that if the script failed for w/e reason, then the old files weren't properly restored.
The repro on my machine is something like:
mac sqlc
. The script should fail.We fix this by using the
trap
command, which is basically like Go'sdefer
, but for bashscripts!