tapcfg: allow to configure lnd RPC timeout, increase default val #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
requested review from
Roasbeef,
ffranr and
GeorgeTsagk
and removed request for
Roasbeef
Pull Request Test Coverage Report for Build 11778382498Details
💛 - Coveralls |
GeorgeTsagk
approved these changes
Nov 11, 2024
|
pending lint / sample conf |
This fixes an issue where tapd would shut down because querying channels on a slow lnd would time out: ``` 2024-10-30 10:06:21.535 [DBG] STAT: Setting the taproot-assets sub-server as errored: received critical error from sub-server (taproot-assets), shutting down: failed to handle outgoing message: error adding local alias: add alias: error listing local channels: rpc error: code = DeadlineExceeded desc = context deadline exceeded ```
This makes it more clear to the user what valid units are for any duration based config entries.
Ignore long lines in the files we touched in the previous commit. For the tapcfg/config.go file which only contains config elements, we add the ignore directive to the whole file.
guggero
force-pushed
the
lnd-rpc-timeout
branch
from
84e6cd1 to
a8e6336
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where tapd would shut down because querying channels on a slow lnd would time out:
Will add a similar PR to
litd, as there thelndclientis created in a single place for all sub servers, so this daemon specific value would be ignored.