-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: add TLS support to basic price oracle service #1140
Conversation
Pull Request Test Coverage Report for Build 11217147728Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
I can still see some magic numbers in there, but that's expected for essentially a mock. But I just wanted to flag it.
Also, this server now only works with TLS. That's what we want, right?
Made a nit comment, but nothing that would block merging.
This commit adds basic TLS support to the example price oracle service. When connecting to the RPC price oracle, Tapd now assumes TLS. TLS certificate authentication is skipped by Tapd.
@gijswijs yes, I think it will do for now. And tapd expects that right now. |
This does solve the communication error between litd and the oracle in my testing. |
That's fine IMO. We just want to make sure that it can work with tapd out of the box. |
2263a38
to
967415b
Compare
I've added logging to this and the format is sub-optimal. So I will improve before merge. |
Compare subject asset to supported asset using both string and byte slice instead of just string.
66c0cae
to
2d0b4a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐄
This commit adds basic TLS support to the example price oracle service. When connecting to the RPC price oracle, Tapd now assumes TLS. TLS certificate authentication is skipped by Tapd.
Simplify integration of the example price oracle with Tapd. (Hopefully helpful for @HannahMR )