build: add GOEXPERIMENT=loopvar to build+install directives

The prior commit made sure that no unit tests failed with the new logic
applied. We'll also update our build+install commands so all the
binaries are built with the new loop semantics.

Makefile

@@ -13,8 +13,8 @@ MIGRATE_BIN := $(GO_BIN)/migrate
 
 COMMIT := $(shell git describe --tags --dirty)
 
-GOBUILD := GO111MODULE=on go build -v
-GOINSTALL := GO111MODULE=on go install -v
+GOBUILD := GOEXPERIMENT=loopvar GO111MODULE=on go build -v
+GOINSTALL := GOEXPERIMENT=loopvar GO111MODULE=on go install -v
 GOTEST := GOEXPERIMENT=loopvar GO111MODULE=on go test 
 GOMOD := GO111MODULE=on go mod
 

scripts/release.sh

@@ -176,8 +176,8 @@ function build_release() {
     pushd "${dir}"
 
     green " - Building: ${os} ${arch} ${arm} with build tags '${buildtags}'"
-    env CGO_ENABLED=0 GOOS="$os" GOARCH="$arch" GOARM=$arm GOAMD64="v1" go build -v -trimpath -ldflags="${ldflags}" -tags="${buildtags}" ${PKG}/cmd/tapd
-    env CGO_ENABLED=0 GOOS="$os" GOARCH="$arch" GOARM=$arm GOAMD64="v1" go build -v -trimpath -ldflags="${ldflags}" -tags="${buildtags}" ${PKG}/cmd/tapcli
+    env GOEXPERIMENT=loopvar CGO_ENABLED=0 GOOS="$os" GOARCH="$arch" GOARM=$arm GOAMD64="v1" go build -v -trimpath -ldflags="${ldflags}" -tags="${buildtags}" ${PKG}/cmd/tapd
+    env GOEXPERIMENT=loopvar CGO_ENABLED=0 GOOS="$os" GOARCH="$arch" GOARM=$arm GOAMD64="v1" go build -v -trimpath -ldflags="${ldflags}" -tags="${buildtags}" ${PKG}/cmd/tapcli
     popd
 
     # Add the hashes for the individual binaries as well for easy verification