Skip to content

Commit

Permalink
Merge pull request #896 from lightninglabs/grpc-log-off
Browse files Browse the repository at this point in the history
config: disable internal GRPC logger by default
  • Loading branch information
guggero authored Nov 8, 2024
2 parents cb6977f + 95e289c commit 2150446
Show file tree
Hide file tree
Showing 2 changed files with 53 additions and 7 deletions.
18 changes: 11 additions & 7 deletions config.go
Original file line number Diff line number Diff line change
Expand Up @@ -386,15 +386,19 @@ func loadAndValidateConfig(interceptor signal.Interceptor) (*Config, error) {
// the debug log level(s). In remote lnd mode we have a global log level
// that overwrites all others. In integrated mode we use the lnd log
// level as the master level.
debuglevel := cfg.Lnd.DebugLevel
if cfg.lndRemote {
err = build.ParseAndSetDebugLevels(
cfg.Remote.LitDebugLevel, cfg.Lnd.LogWriter,
)
} else {
err = build.ParseAndSetDebugLevels(
cfg.Lnd.DebugLevel, cfg.Lnd.LogWriter,
)
debuglevel = cfg.Remote.LitDebugLevel
}

// By default, we don't want the GRPC connection-level logger to be
// turned on. So if it isn't specifically mentioned in the debug level
// string, we'll disable it.
if !strings.Contains(debuglevel, GrpcLogSubsystem) {
debuglevel += fmt.Sprintf(",%s=off", GrpcLogSubsystem)
}

err = build.ParseAndSetDebugLevels(debuglevel, cfg.Lnd.LogWriter)
if err != nil {
return nil, err
}
Expand Down
42 changes: 42 additions & 0 deletions docs/release-notes/release-notes-0.13.7.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
# Release Notes

- [Lightning Terminal](#lightning-terminal)
- [Bug Fixes](#bug-fixes)
- [Functional Changes/Additions](#functional-changesadditions)
- [Technical and Architectural Updates](#technical-and-architectural-updates)
- [Integrated Binary Updates](#integrated-binary-updates)
- [LND](#lnd)
- [Loop](#loop)
- [Pool](#pool)
- [Faraday](#faraday)
- [Taproot Assets](#taproot-assets)
- [Contributors](#contributors-alphabetical-order)

## Lightning Terminal

### Bug Fixes

* [Disable the `GRPC` internal low-level connection logger by
default](https://github.com/lightninglabs/lightning-terminal/pull/896).
It can still be enabled by adding `,GRPC=info` at the end of the
`lnd.debuglevel` or `remote.lit-debuglevel` configuration options.

### Functional Changes/Additions

### Technical and Architectural Updates

## Integrated Binary Updates

### LND

### Loop

### Pool

### Faraday

### Taproot Assets

# Contributors (Alphabetical Order)

- Oliver Gugger

0 comments on commit 2150446

Please sign in to comment.