Skip to content

Commit

Permalink
gbn: increase NACK wait time by 2X
Browse files Browse the repository at this point in the history
  • Loading branch information
ViktorTigerstrom committed Nov 13, 2023
1 parent fe046b3 commit a807521
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion gbn/gbn_conn.go
Original file line number Diff line number Diff line change
Expand Up @@ -569,8 +569,17 @@ func (g *GoBackNConn) receivePacketsForever() error { // nolint:gocyclo

// If we recently sent a NACK for the same
// sequence number then back off.
// We wait 2 times the resendTimeout before
// sending a new nack, as this case is likely
// hit if the sender is currently resending
// the queue, and therefore the threads that
// are resending the queue is likely busy with
// the resend, and therefore won't react to the
// NACK we send here in time.
if lastNackSeq == g.recvSeq &&
time.Since(lastNackTime) < g.resendTimeout {
time.Since(lastNackTime) < g.resendTimeout*2 {

log.Tracef("Recently sent NACK")

continue
}
Expand Down

0 comments on commit a807521

Please sign in to comment.