Skip to content

gbn+mailbox: cleanup & prefixed logger #396

gbn+mailbox: cleanup & prefixed logger

gbn+mailbox: cleanup & prefixed logger #396

Triggered via pull request November 20, 2023 11:37
Status Failure
Total duration 6m 29s
Artifacts

main.yml

on: pull_request
Matrix: run unit tests
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 5 warnings
lint code: gbn/gbn_conn.go#L269
expressions should not be cuddled with blocks (wsl)
lint code: gbn/gbn_conn.go#L287
expressions should not be cuddled with blocks (wsl)
lint code: gbn/gbn_conn.go#L70
found a struct that contains a context.Context field (containedctx)
lint code: gbn/gbn_client.go#L165
type assertion must be checked (forcetypeassert)
lint code: gbn/gbn_conn.go#L610
err113: do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"received unexpected message: %T\",\n\tmsg)" (goerr113)
lint code: gbn/gbn_client.go#L81
variable name 'b' is too short for the scope of its usage (varnamelen)
lint code: gbn/gbn_conn.go#L461
variable name 'b' is too short for the scope of its usage (varnamelen)
lint code: gbn/queue_test.go#L10
variable name 'q' is too short for the scope of its usage (varnamelen)
lint code: gbn/gbn_server.go#L67
variable name 'b' is too short for the scope of its usage (varnamelen)
lint code: gbn/queue.go#L51
parameter name 's' is too short for the scope of its usage (varnamelen)
run unit tests (unit)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
run unit tests (unit-race)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
lint code
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
run itests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build package and wasm
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/