api: check for an output to be unspent. #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziggie1984
force-pushed
the
fix-unspent-utxo-api
branch
2 times, most recently
from
f97f60b to
ea20722
Compare
ziggie1984
force-pushed
the
fix-unspent-utxo-api
branch
2 times, most recently
from
26f9d9f to
0bca88e
Compare
ziggie1984
force-pushed
the
fix-unspent-utxo-api
branch
from
0bca88e to
4571363
Compare
|
PR was tested by the person who run into this problem, and it worked for him. |
|
Hey Ziggie. Thanks for the fix. But is it possible you're using an old base? I fixed this in 83aa752, which just hasn't been in a release yet. Can create a release if that helps. |
|
True, always a step ahead :). I think it makes sense to release a new version with this bugfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where we would assume outputs are unspent although they were not.
Example:
while sweeping the remote close of this channel:
https://mempool.space/address/bc1q96vq7jhl552ucgy79q7zqny27jmlgq6nmspmcvuw97dgsdedlpusnxamhj
the
to_remoteaddr has unfortunately two outputs of two different channel closures (prob. some kind of LND bug), so when querying for the unspent addr utxos, we need to make sure before including the utxo we query the mempool for the spendness of this UTXO.to_remote addr has two channel closures associated with it:
https://mempool.space/address/bc1qkvtux0hk28qtn7njdjlym2pmhtq799r36yt8a4cuqs0ejm6z520sz4xkqe