Add log4j as Slf4j Impl. #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since SLF4J is only a logging facade and does not provide a concrete logging implementation, we need to include `log4j-slf4j-impl` as a dependency. This allows SLF4J to route logging calls to Log4j-2, which acts as the backend logging framework.
arik-so
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since SLF4J is only a logging facade and does not
provide a concrete logging implementation, we need to include
log4j-slf4j-implas a dependency.This allows SLF4J to route logging calls to Log4j-2, which acts as the backend logging framework.
Related: https://discord.com/channels/915026692102316113/1184952845720617012/1316310889951002634
Tested this with local docker run.
Earlier i was getting error
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".After the fix i could see "ERROR org.vss.api.PutObjectsApi - Exception in PutObjectsApi:
2024-12-11 14:56:22 com.google.protobuf.InvalidProtocolBufferException: While parsing a protocol message," on incorrect message.