Update Project level Readme and add implementation level Readme. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
reviewed
Oct 23, 2024
| ### Prerequisites | ||
|
|
||
| - Install Gradle (https://gradle.org/install/). | ||
| - Install JDK 17 (https://docs.aws.amazon.com/corretto/latest/corretto-17-ug/). |
There was a problem hiding this comment.
I'm a bit out of the Java world. Why would we prefer Amazon?
There was a problem hiding this comment.
Amazon provides LTS releases for open jdk, tested for production and performance with security bugfixes(LTS). JDK 17 is one of the LTS releases. In theory, anything above 17 should work.
Moreover, correto-jdk-17-Lts's last release was last week which addressed 4 CVE's whereas openjdk has jdk-17 only in archived directory.
Earlier I refrained from providing any link for jdk install but this one had much better installation instructions as well.
|
Addressed comments. |
jkczyz
reviewed
Oct 24, 2024
|
Addressed comments. |
|
Squashed fixups |
jkczyz
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.