-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds lightning-transaction-sync in favor of Confirm #251
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for lightningdevkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
If you are connecting full blocks or using BIP 157/158, then it is recommended to use | ||
LDK's [`lightning_block_sync`](https://docs.rs/lightning-block-sync/*/lightning_block_sync/) crate as in the example above: the high-level steps that must be done for both `ChannelManager` and each `ChannelMonitor` are as follows: | ||
|
||
1. Get the last blockhash that each object saw. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of the examples given in these steps are bindings-specific and would look differently in Rust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah agree, generally speaking, the kotlin & swift examples approach things from a mobile-first perspective but I've not seen any simple examples of CBF in a mobile context yet. Hopefully, with BDK 1.0 it's possible. Current mobile users are opting for Esplora/Electrum and we have some coverage there.
Co-authored-by: Elias Rohrer <[email protected]>
c91ff23
to
4f8109a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM.
Not sure if we want to hold off merging this until the next bindings release to immediately include the tx-sync
examples?
**What it's used for:** this step is only necessary if you're restarting and have open channels. This step ensures that LDK channel state is up-to-date with the bitcoin blockchain | ||
**What it's used for:** this step is only necessary if you're restarting and have open channels. This step ensures that LDK channel state is up-to-date with the bitcoin blockchain. | ||
|
||
There are 2 main options for synchronizing to chain on startup: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Spell out numbers zero to ten.
Yeah let's hold off for that, sgtm! |
Can add examples for kotlin and swift examples once exposed in the bindings.
Also probably worth adding CBF examples once available in BDK 1.0
Closes #249