Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Basic project description and README.md #29

Closed
wants to merge 3 commits into from

Conversation

G8XSU
Copy link
Contributor

@G8XSU G8XSU commented Dec 4, 2024

  • Add basic project description and README.md

@G8XSU G8XSU requested a review from jkczyz December 4, 2024 21:30
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, otherwise LGTM

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
🚧 **Work in Progress**:
- **APIs Under Development**: Expect breaking changes as the project evolves.
- **Potential Bugs and Inconsistencies**: While progress is being made toward stability, unexpected behavior may occur.
- **Improved Logging and Error Handling Coming Soon**: Current error handling is rudimentary(specially for CLI), and usability improvements are actively being worked on.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we already speak about more of the planned features, e.g., LSP service integration? Or rather not to not spill the beans just yet?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to include that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many features planned or upcoming. I didn't mention those because it wouldn't be exhaustive.
This list only includes stability/critical list for general readiness. 😅
As in what is required to get out of "wip" status.

README.md Show resolved Hide resolved
🚧 **Work in Progress**:
- **APIs Under Development**: Expect breaking changes as the project evolves.
- **Potential Bugs and Inconsistencies**: While progress is being made toward stability, unexpected behavior may occur.
- **Improved Logging and Error Handling Coming Soon**: Current error handling is rudimentary(specially for CLI), and usability improvements are actively being worked on.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to include that.

### Features

- **Out-of-the-Box Lightning Node**:
- Deploy a Lightning Network node with minimal configuration, no coding required.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it should be mentioned here or elsewhere, but might be worth stating what can be configured somewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is mentioned in "Configuration" section right before ## building

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean at a more high-level like you can provide your own KvStore, etc.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to leave out now if we don't have a way of configuring that, of course.

Copy link
Contributor Author

@G8XSU G8XSU Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't configure kvstore right now without forking

@G8XSU G8XSU requested review from jkczyz and tnull December 5, 2024 17:30
Copy link

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there needs to be another push for resolved comments?

@G8XSU G8XSU closed this by deleting the head repository Dec 6, 2024
@G8XSU
Copy link
Contributor Author

G8XSU commented Dec 6, 2024

This PR got closed because of me deleting the fork of private repo.
Replaced by #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants