Fixes effects issues with direct obj assingment #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When complete object is assiged to state variable with equal operator then effects associated with in template on assining object properties are not triggering. Here Object.assign is working as expected but users feels this is odd to do instead of assignment operator Moved the object.assign operation to reactive proxy set trap so that it will invoke set traps of indiviual key Signed-off-by: Suresh Kumar Gangumalla <[email protected]>
Object.assing is only required for pure objects as arrays direct assignment is triggering effects without an issue Signed-off-by: Suresh Kumar Gangumalla <[email protected]>
|
Latest Changes are working as expected for object direct assignment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When complete object is assiged to state variable with equal operator then effects associated with in template on assining object properties are not triggering.
Here Object.assign is working as expected but users feels this is odd to do instead of assignment operator
Moved the object.assign operation to reactive proxy set trap so that it will invoke set traps of indiviual key