Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/get expiring deals #8

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Fix/get expiring deals #8

wants to merge 12 commits into from

Conversation

parva-jain
Copy link
Collaborator

  • MarketAPI.getDealTerm returns the start epoch and duration in epochs(not end epoch) for a deal proposal.
  • The if statement in getExpiringDeals function was written considering that later value is end epoch of deal.
  • epoch needs to be at the left side of the operator to be failproof at larger values(to avoid making right side negative).

@ravish1729 ravish1729 changed the base branch from staging to main November 3, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parva-jain @lordshashank