fix: workflow input decoding #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
java-sdk-protobuf
kalix-runtime
aludwiko
reviewed
Oct 30, 2023
| // if that's the case, we need to patch the message using the typeUrl from the expected input class | ||
| private def decodeInput(messageCodec: MessageCodec, result: ScalaPbAny, expectedInputClass: Class[_]) = | ||
| if (result.typeUrl == JsonSupport.KALIX_JSON + "object") { | ||
| val typeUrl = messageCodec.typeUrlFor(expectedInputClass) |
There was a problem hiding this comment.
Would that work when the workflow queries the view, and the view itself was not used yet, so the messaceCodec might not have the expectedInputClass entry?
There was a problem hiding this comment.
The input classes are registered in the messageCodec when we register the component. And that's valid for all components. So, the answer is yes.
The problem here is that we were always relying on the incoming typeUrl which is simply not reliable enough in this situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/lightbend/kalix-proxy/issues/2135