bug: disabling integration tracing test after pull/#1810 #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octonato
reviewed
Oct 23, 2023
| @@ -50,7 +51,7 @@ public TracingIntegratonTest(ApplicationContext applicationContext) { | |||
| super(applicationContext, config); | |||
| } | |||
|
|
|||
| @Test | |||
| @Ignore //disabled ATM for https://github.com/lightbend/kalix-jvm-sdk/pull/1810 | |||
There was a problem hiding this comment.
I'm confused now.
In #1810, we added the Ignore annotation and that's what we have now in main.
I think the diff should not even show here.
There was a problem hiding this comment.
Right. I mess the order I guess. I would have seen this if I would have made a rebase from main. Never mind.
There was a problem hiding this comment.
But that's also surprising. Ok that you needed to rebase, but GitHub compares your branch to main since you were planning to merge it into main and therefore it should not show any diff.
Possibly, the PR was made before #1810 got merged. Still, I thought that GH would refresh the diff anyway, but I might be wrong. 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #1810