Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for huge memory units #663

Merged
merged 8 commits into from
Feb 17, 2020
Merged

Support for huge memory units #663

merged 8 commits into from
Feb 17, 2020

Conversation

mpryahin
Copy link
Contributor

@mpryahin mpryahin commented Dec 26, 2019 •
edited
Loading

Added support for memory units which don't fit in a long when transformed to bytes.
closes #172

@mpryahin mpryahin mentioned this pull request Dec 26, 2019
Closed
havocp
havocp reviewed Jan 8, 2020
View reviewed changes
Copy link
Collaborator

@havocp havocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me overall, I think my main suggestion is I'd lean toward removing the code duplication, even if it means we allocate a BigInteger only to range check it and then convert to Long.

config/src/main/java/com/typesafe/config/ConfigMemorySize.java Outdated Show resolved Hide resolved
config/src/main/java/com/typesafe/config/impl/SimpleConfig.java Outdated Show resolved Hide resolved
config/src/main/java/com/typesafe/config/impl/SimpleConfig.java Outdated Show resolved Hide resolved
config/src/main/java/com/typesafe/config/impl/SimpleConfig.java Outdated Show resolved Hide resolved
config/src/main/java/com/typesafe/config/impl/SimpleConfig.java Outdated Show resolved Hide resolved
havocp
havocp reviewed Jan 10, 2020
View reviewed changes
Copy link
Collaborator

@havocp havocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Main remaining issue I think is an ABI break if we go from BadValue=>IllegalArgumentException in a couple of places.

config/src/main/java/com/typesafe/config/ConfigMemorySize.java Show resolved Hide resolved
config/src/main/java/com/typesafe/config/impl/SimpleConfig.java Outdated Show resolved Hide resolved
config/src/main/java/com/typesafe/config/impl/SimpleConfig.java Outdated Show resolved Hide resolved
config/src/main/java/com/typesafe/config/impl/SimpleConfig.java Outdated Show resolved Hide resolved
@mpryahin
Copy link
Contributor Author

Hello @havocp,
sorry for bothering, could you please review the final changes so that we can merge the PR into the main branch?
Thank you in advance!

havocp
havocp approved these changes Jan 17, 2020
View reviewed changes
Copy link
Collaborator

@havocp havocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience - this looks great to me!

config/src/main/java/com/typesafe/config/impl/SimpleConfig.java Outdated Show resolved Hide resolved
@mpryahin
Copy link
Contributor Author

@havocp thank you so much! Looking forward to having it merged when you have time.

@mpryahin
Copy link
Contributor Author

Hello @havocp ,
I'm sorry for bothering, just writing to ask if there is anything else to be done form my side?
Thank you.

@havocp havocp merged commit d0271d4 into lightbend:master Feb 17, 2020
@havocp
Copy link
Collaborator

havocp commented Feb 17, 2020

Thanks! Appreciate the work on this. I don't know when Lightbend will next make a release.

@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Merged
@ekrich ekrich mentioned this pull request Jun 16, 2023
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havocp havocp havocp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add BigInteger version of getBytes
2 participants
@mpryahin @havocp