Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jardiff-sbt #52

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martijnhoekstra
Copy link

Split the existing jardiff in a library and cli project and add an sbt project depending on the library project.

The main functionality is setting the reference version jardiffReferenceVersion := "1.3.4" and then running the thing jardiff and the jardiff emerges.

  • Is this a good idea at all?
  • If it is, should sbt-jardiff live here, or elsewhere?
  • This would need publishing and packaging. The packaging for the CLI tool is probably unchanged, but the library part (and sbt plugin if it should live here) would need to be published to maven central.
  • I bumped the version number to 2.0.0 and used a single overall version number, mostly for ease. Maybe it makes more sense to give everything their own version?

cr. scala/scala-dev#428

@martijnhoekstra
Copy link
Author

Also, closes #4

@SethTisue
Copy link
Contributor

@martijnhoekstra not sure if you even still have any interest in this, but if you do, I'm here to make sure we can get it across the finish line.

I have enabled Scala Steward and merged a ton of version bumps, to get the whole project on a more modern footing.

Is this a good idea at all?

I believe so.

If it is, should sbt-jardiff live here, or elsewhere?

I suggest it live elsewhere, primarily on the grounds that it's not something the Scala team necessarily wants to maintain indefinitely. Whereas jardiff is. (It may not seem so, since this PR was neglected for so long, but we are invested in keeping jardiff in at least minimal working order, since we definitely use it from time to time when QAing this or that.)

This would need publishing and packaging. The packaging for the CLI tool is probably unchanged, but the library part (and sbt plugin if it should live here) would need to be published to maven central.

Want to add sbt-ci-release? I can add the necessary secrets for Maven Central.

I bumped the version number to 2.0.0 and used a single overall version number, mostly for ease. Maybe it makes more sense to give everything their own version?

(If the sbt plugin lives elsewhere, is this still a question?)

@SethTisue SethTisue marked this pull request as draft April 1, 2022 07:17
@mdedetrich mdedetrich mentioned this pull request Jul 2, 2023
@mdedetrich mdedetrich mentioned this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants