Remove warnings

build.sbt

@@ -3,24 +3,58 @@ import LiftSbtHelpers._
 
 organization in ThisBuild          := "net.liftweb"
 version in ThisBuild               := "3.6.0-SNAPSHOT"
-homepage in ThisBuild              := Some(url("http://www.liftweb.net"))
-licenses in ThisBuild              += ("Apache License, Version 2.0", url("http://www.apache.org/licenses/LICENSE-2.0.txt"))
+homepage in ThisBuild              := Some(url("https://www.liftweb.net"))
+licenses in ThisBuild              += ("Apache License, Version 2.0", url("https://www.apache.org/licenses/LICENSE-2.0.txt"))
 startYear in ThisBuild             := Some(2006)
 organizationName in ThisBuild      := "WorldWide Conferencing, LLC"
 
 val scala211Version = "2.11.12"
+// Bug in compiler for versions 2.12.13, 14 and 15. StringBuiledr.length()
+// cannot be written with ().
 val scala212Version = "2.12.12"
-val scala213Version = "2.13.2"
+val scala213Version = "2.13.7"
 
 val crossUpTo212 = Seq(scala212Version, scala211Version)
 val crossUpTo213 = scala213Version +: crossUpTo212
 
-scalaVersion in ThisBuild          := scala212Version
+scalaVersion       in ThisBuild    := scala212Version
 crossScalaVersions in ThisBuild    := crossUpTo212 // default everyone to 2.12 for now
 
 libraryDependencies in ThisBuild ++= Seq(specs2, specs2Matchers, specs2Mock, scalacheck, scalactic, scalatest)
+libraryDependencies in ThisBuild ++= {
+  scalaVersion.value.split("\\.") match {
+    case Array("2", m, p) =>
+      val minor = m.toInt
+      val patch = p.toInt
+
+      // See published versions at: https://repo1.maven.org/maven2/com/github/ghik/
+      val silencerVersion = minor match {
+          case 11 => Some("1.7.7")
+          case 12 => if (patch <= 10) Some("1.6.0")
+                     else if (patch <= 12) Some("1.7.1")
+                     else None // Some("1.7.7"), nowarn is backported since 2.12.13
+          case 13 => if (patch == 1) Some("1.6.0")
+                     else None // Some("1.7.7"), nowarn is backported since 2.13.2
+        }
 
-scalacOptions in ThisBuild ++= Seq("-deprecation")
+      (
+        // Allows @scala.annotation.nowarn
+        silencerVersion match {
+          case Some(version) =>
+            List(
+              compilerPlugin("com.github.ghik" % "silencer-plugin" % version cross CrossVersion.full),
+              "com.github.ghik" % "silencer-lib" % version % Provided cross CrossVersion.full,
+              )
+          case None => Nil
+        }
+      ) ++ (
+        // Allows import scala.jdk.CollectionConverters._
+        if (minor < 13) List(scala_compat)
+        else Nil
+      )
+    case _ => Nil
+  }
+}
 
 // Settings for Sonatype compliance
 pomIncludeRepository in ThisBuild := { _ => false }
@@ -123,7 +157,6 @@ lazy val util =
       description := "Utilities Library",
       parallelExecution in Test := false,
       libraryDependencies ++= Seq(
-        scala_compiler(scalaVersion.value),
         joda_time,
         joda_convert,
         commons_codec,
@@ -269,6 +302,12 @@ lazy val mongodb =
         )
       }
     )
+    .settings(
+      // Because of one warning: While parsing annotations in
+      // mongodb-driver-core-3.12.7.jar(com/mongodb/lang/Nullable.class): could
+      // not find MAYBE in enum <none>.
+      scalacOptions ~= ((opts) => opts.filterNot(Set("-Xfatal-warnings")))
+    )
 
 lazy val mongodb_record =
   persistenceProject("mongodb-record")
@@ -277,3 +316,8 @@ lazy val mongodb_record =
       crossScalaVersions := crossUpTo213,
       parallelExecution in Test := false
     )
+    .settings(
+      // Because of multiple warnings about using deprecated method instead of
+      // BsonableField.
+      scalacOptions ~= ((opts) => opts.filterNot(Set("-Xfatal-warnings")))
+    )

core/actor/src/main/scala/net/liftweb/actor/LAFuture.scala

@@ -92,7 +92,7 @@ class LAFuture[T](val scheduler: LAScheduler = LAScheduler, context: Box[LAFutur
    * value has not been satisfied, execute the function
    * when the value is satified
    */
-  def foreach(f: T => Unit) {
+  def foreach(f: T => Unit): Unit = {
     onSuccess(f)
   }
 
@@ -188,7 +188,7 @@ class LAFuture[T](val scheduler: LAScheduler = LAScheduler, context: Box[LAFutur
   /**
    * Abort the future.  It can never be satified
    */
-  def abort() {
+  def abort(): Unit = {
     fail(Empty)
   }
 
@@ -197,7 +197,7 @@ class LAFuture[T](val scheduler: LAScheduler = LAScheduler, context: Box[LAFutur
    *
    * @param f the function to execute on success.
    */
-  def onSuccess(f: T => Unit) {
+  def onSuccess(f: T => Unit): Unit = {
     val contextFn = LAFuture.inContext(f, context)
     synchronized {
       if (satisfied) {LAFuture.executeWithObservers(scheduler, () => contextFn(item))} else
@@ -212,7 +212,7 @@ class LAFuture[T](val scheduler: LAScheduler = LAScheduler, context: Box[LAFutur
    *
    * @param f the function to execute. Will receive a Box[Nothing] which may be a Failure if there's exception data
    */
-  def onFail(f: Box[Nothing] => Unit) {
+  def onFail(f: Box[Nothing] => Unit): Unit = {
     val contextFn = LAFuture.inContext(f, context)
     synchronized {
       if (aborted) LAFuture.executeWithObservers(scheduler, () => contextFn(failure)) else
@@ -227,7 +227,7 @@ class LAFuture[T](val scheduler: LAScheduler = LAScheduler, context: Box[LAFutur
    *
    * @param f the function to execute on completion of the Future
    */
-  def onComplete(f: Box[T] => Unit) {
+  def onComplete(f: Box[T] => Unit): Unit = {
     val contextFn = LAFuture.inContext(f, context)
     synchronized {
       if (satisfied) {LAFuture.executeWithObservers(scheduler, () => contextFn(Full(item)))} else
@@ -240,15 +240,15 @@ class LAFuture[T](val scheduler: LAScheduler = LAScheduler, context: Box[LAFutur
    * If the execution fails, do this
    * @param e
    */
-  def fail(e: Exception) {
+  def fail(e: Exception): Unit = {
     fail(Failure(e.getMessage, Full(e), Empty))
   }
 
   /**
    * If the execution fails as a Box[Nothing], do this
    * @param e
    */
-  def fail(e: Box[Nothing]) {
+  def fail(e: Box[Nothing]): Unit = {
     synchronized {
       if (!satisfied && !aborted) {
         aborted = true
@@ -311,14 +311,14 @@ object LAFuture {
    *
    * @param future
    */
-  private def notifyObservers(future: LAFuture[_]) {
+  private def notifyObservers(future: LAFuture[_]): Unit = {
     val observers = threadInfo.get()
     if (null eq observers) {} else {
       observers.foreach(_(future))
     }
   }
 
-  private def executeWithObservers(scheduler: LAScheduler, f: () => Unit) {
+  private def executeWithObservers(scheduler: LAScheduler, f: () => Unit): Unit = {
     val cur = threadInfo.get()
     scheduler.execute(() => {
       val old = threadInfo.get()

core/actor/src/main/scala/net/liftweb/actor/LAPinger.scala

@@ -75,7 +75,7 @@ object LAPinger {
     try {
       service.schedule(r, delay, TimeUnit.MILLISECONDS)
     } catch {
-      case e: RejectedExecutionException => throw PingerException(msg + " could not be scheduled on " + to, e)
+      case e: RejectedExecutionException => throw PingerException(msg.toString + " could not be scheduled on " + to, e)
     }
   }
 

core/actor/src/main/scala/net/liftweb/actor/LiftActor.scala

@@ -71,7 +71,7 @@ object LAScheduler extends LAScheduler with Loggable {
                                })
 
       def execute(f: () => Unit): Unit =
-      es.execute(new Runnable{def run() {
+      es.execute(new Runnable{def run(): Unit = {
         try {
           f()
         } catch {
@@ -93,7 +93,7 @@ object LAScheduler extends LAScheduler with Loggable {
    *
    * @param f the function to execute on another thread
    */
-  def execute(f: () => Unit) {
+  def execute(f: () => Unit): Unit = {
     synchronized {
       if (exec eq null) {
         exec = createExecutor()
@@ -102,7 +102,7 @@ object LAScheduler extends LAScheduler with Loggable {
     }
   }
 
-  def shutdown() {
+  def shutdown(): Unit = {
     synchronized {
       if (exec ne null) {
         exec.shutdown()
@@ -129,7 +129,7 @@ trait SpecializedLiftActor[T] extends SimpleActor[T]  {
     if (f(this)) Full(this) else next.find(f)
     */
 
-    def remove() {
+    def remove(): Unit = {
       prev.next = next
       next.prev = prev
     }
@@ -221,7 +221,7 @@ trait SpecializedLiftActor[T] extends SimpleActor[T]  {
     toDo()
   }
 
-  private def processMailbox(ignoreProcessing: Boolean) {
+  private def processMailbox(ignoreProcessing: Boolean): Unit = {
     around {
       proc2(ignoreProcessing)
     }
@@ -240,7 +240,7 @@ trait SpecializedLiftActor[T] extends SimpleActor[T]  {
     case Nil => f
     case xs => CommonLoanWrapper(xs)(f)
   }
-  private def proc2(ignoreProcessing: Boolean) {
+  private def proc2(ignoreProcessing: Boolean): Unit = {
     var clearProcessing = true
     baseMailbox.synchronized {
       if (!ignoreProcessing && processing) return
@@ -404,7 +404,7 @@ with ForwardableActor[Any, Any] {
 
 
 
-  protected final def forwardMessageTo(msg: Any, forwardTo: TypedActor[Any, Any]) {
+  protected final def forwardMessageTo(msg: Any, forwardTo: TypedActor[Any, Any]): Unit = {
     if (null ne responseFuture) {
       forwardTo match {
         case la: LiftActor => la ! MsgWithResp(msg, responseFuture)
@@ -507,7 +507,7 @@ with ForwardableActor[Any, Any] {
   * The Actor should call this method with a reply
   * to the message
   */
-  protected def reply(v: Any) {
+  protected def reply(v: Any): Unit = {
     if (null ne responseFuture) {
       responseFuture.satisfy(v)
     }

core/actor/src/test/scala/net/liftweb/actor/LAFutureSpec.scala

@@ -2,7 +2,6 @@ package net.liftweb.actor
 
 import net.liftweb.common.{Box, Failure, Full}
 import org.specs2.mutable.Specification
-import java.util.concurrent.atomic.AtomicBoolean
 
 class LAFutureSpec extends Specification {
   sequential

core/common/src/main/scala/net/liftweb/common/Box.scala

@@ -17,7 +17,6 @@
 package net.liftweb
 package common
 
-import scala.language.implicitConversions
 import scala.language.existentials
 import scala.reflect.Manifest
 
@@ -1117,11 +1116,11 @@ object BoxOrRaw {
   implicit def rawToBoxOrRaw[T, Q <: T](r: Q): BoxOrRaw[T] =
     RawBoxOrRaw(r: T)
 
-  implicit def boxToBoxOrRaw[T, Q <% T](r: Box[Q]): BoxOrRaw[T] = {
+  implicit def boxToBoxOrRaw[T, Q](r: Box[Q])(implicit qToT: Q => T): BoxOrRaw[T] = {
     BoxedBoxOrRaw(r.map(v => v: T))
   }
 
-  implicit def optionToBoxOrRaw[T, Q <% T](r: Option[Q]): BoxOrRaw[T] = {
+  implicit def optionToBoxOrRaw[T, Q](r: Option[Q])(implicit qToT: Q => T): BoxOrRaw[T] = {
     BoxedBoxOrRaw(r.map(v => v: T))
   }
 

core/common/src/main/scala/net/liftweb/common/CombinableBox.scala

@@ -17,7 +17,6 @@
 package net.liftweb 
 package common
 
-import scala.language.implicitConversions
 
 /**
  * Via an `[[HLists.HList HList]]` containing a collection of `[[Box]]`, either generates an

core/common/src/main/scala/net/liftweb/common/Conversions.scala

@@ -17,7 +17,6 @@
 package net.liftweb 
 package common 
 
-import scala.language.implicitConversions
 import scala.xml._
 
 /*
@@ -48,7 +47,7 @@ sealed trait StringOrNodeSeq {
  * their needs dictate.
  */
 object StringOrNodeSeq {
-  implicit def strTo[T <% String](str: T): StringOrNodeSeq = 
+  implicit def strTo[T](str: T)(implicit tToString: T => String): StringOrNodeSeq =
     new StringOrNodeSeq {
       def nodeSeq: NodeSeq = Text(str)
     }

core/common/src/main/scala/net/liftweb/common/FuncJBridge.scala

@@ -17,7 +17,6 @@
 package net.liftweb 
 package common
 
-import scala.language.implicitConversions
 
 object FuncJBridge extends FuncJBridge
 

core/common/src/main/scala/net/liftweb/common/HList.scala

@@ -109,7 +109,7 @@ object HLists {
    * }}}
    */
   final case class :+:[+H, +T <: HList](head: H, tail: T) extends HList {
-    override def toString = head + " :+: " + tail
+    override def toString = head.toString + " :+: " + tail
   }
 
   /**
@@ -129,7 +129,7 @@ object HLists {
       hlist match {
         case HNil =>
           0
-        case head :+: rest =>
+        case head@_ :+: rest =>
           1 + rest.length
       }
     }