refactor: metrics replaced with action callback props

[manneredboor]

Description

The idea is to replace specific metrics argument during ReefKnotWalletsModal setup with more generic appropriate action callback props, so the connector buttons should not know anything about or define any metrics structure of the destination project.

Code review notes

The MetricsProp structure was removed. It was overcomplicated with such paths as

• metrics?.events?.click?.handlers.onClickTermsAccept
• metrics?.events?.click?.handlers.walletsMore
• metrics?.events?.click?.handlers.walletsLess
• metrics?.events?.click?.handlers[walletId]

It was replaced with plain callbacks:

• onClickTermsAccept({ isAccepted })
• onClickWalletsMore()
• onClickWalletsLess()
• onConnectStart({ walletId })
• onConnectSuccess({ walletId })

Testing notes

Affected metric events should work the same way as before:

• Terms acceptance events
• Wallets click and connection events
• Show/hide more wallets event

Also there was a logic error found in the way how successfully connection metric event was accounted for Ledger HID. Please, give some attention to Ledger HID connection, to ensure it works fine.

[changeset-bot]

⚠️ No Changeset found

Latest commit: c4eda62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR