Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update Ledger Live error handling #544

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: update Ledger Live error handling #544

merged 1 commit into from
Nov 21, 2024

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Nov 20, 2024 •
edited
Loading

Description

  • handle permit signing reject(due to user or blind signing off) for Ledger Live
  • no way to determine user or blind sign reject( but better than not enough ether for gas
  • should be resolved once Ledger deploys permits metadata for stETH and wstETH

Demo

image

Code review notes

Testing notes

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@Jeday Jeday requested review from a team as code owners November 20, 2024 07:46
@preview-stands
Copy link

preview-stands bot commented Nov 20, 2024 •
edited
Loading

Preview stand status

Stand was demolished

@itaven itaven merged commit c1e4723 into develop Nov 21, 2024
6 checks passed
@itaven itaven deleted the feature/si-1702-ledger-live-not-enough-gas branch November 21, 2024 12:17
@itaven itaven mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solidovic solidovic solidovic approved these changes

@manneredboor manneredboor manneredboor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jeday @manneredboor @solidovic @itaven