Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display balances #259

Merged
merged 9 commits into from
Mar 7, 2024
Merged

Display balances #259

merged 9 commits into from
Mar 7, 2024

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Feb 29, 2024

Description

For all UI components that used loader, added error handling that shows N/A on all pages, excluding Rewards.
#237 was accidently overtaken in this, but all code from there was incorporated.

Demo

image
image

Testing notes

We need to check all pages and run all txs on tesnet.

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@Jeday Jeday requested review from a team as code owners February 29, 2024 11:44
@preview-stands
Copy link

preview-stands bot commented Feb 29, 2024

Preview stand status

Stand was demolished

manneredboor
manneredboor previously approved these changes Feb 29, 2024
DiRaiks
DiRaiks previously approved these changes Mar 4, 2024
@Jeday Jeday dismissed stale reviews from DiRaiks and manneredboor via d93cb15 March 5, 2024 12:54
manneredboor
manneredboor previously approved these changes Mar 6, 2024
…get into feature/si-1290-fix-display-balances
@itaven itaven merged commit 0ec2a6c into develop Mar 7, 2024
6 checks passed
@itaven itaven deleted the feature/si-1290-fix-display-balances branch March 7, 2024 08:37
@jake4take jake4take mentioned this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants