Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use token max amount limit after gas #239

Merged
merged 1 commit into from
Feb 21, 2024
Merged

fix: use token max amount limit after gas #239

merged 1 commit into from
Feb 21, 2024

Conversation

manneredboor
Copy link
Contributor

Description

if user has more ETH than the limit, if he clicks to Max button, the amount to be <LIMIT - GAS>
Expected result: the amount equals with limit

Checklist:

  • Checked the changes locally.

@manneredboor manneredboor requested review from a team as code owners February 19, 2024 12:15
@preview-stands
Copy link

preview-stands bot commented Feb 19, 2024 •
edited
Loading

Preview stand status

Stand was demolished

@itaven itaven merged commit 37ebbed into develop Feb 21, 2024
6 checks passed
@itaven itaven deleted the feature/si-1261-max-button-error-if-eth-balance-more-current-limit branch February 21, 2024 05:52
@itaven itaven mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeday Jeday Jeday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manneredboor @Jeday @itaven