Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 1inch to aggregators #230

Merged
merged 9 commits into from
Feb 20, 2024
Merged

Return 1inch to aggregators #230

merged 9 commits into from
Feb 20, 2024

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Feb 9, 2024 •
edited
Loading

Description

  • reworked 1inch endpoint to work with key and for both withdrawal integration and stake integration
  • reworked withdrawal integrations to be configurable
  • put back 1inch integration
  • 1inch stake banner
  • API tests
  • Added oneInchDiscount event

Demo

Withdrawals
image
Stake Banner
image

Code review notes

  • Reworked api/oneinch-rate to accept amounts.
  • Reworked swap banner and withdraw integrations to be enabled via configs.

Testing notes

Use setMockDiscountRate(1.01) and reload page to force enable stake swap banner on testing envs.

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@Jeday Jeday marked this pull request as ready for review February 12, 2024 11:18
@Jeday Jeday requested review from a team as code owners February 12, 2024 11:18
@Jeday Jeday marked this pull request as draft February 12, 2024 11:18
@preview-stands
Copy link

preview-stands bot commented Feb 12, 2024 •
edited
Loading

Preview stand status

Stand was demolished

@Jeday Jeday marked this pull request as ready for review February 19, 2024 11:06
DiRaiks
DiRaiks previously approved these changes Feb 19, 2024
View reviewed changes
@Jeday
Merge branch 'develop' of github.com:lidofinance/ethereum-staking-wid…
af024c3 
…get into feature/si-1228-return-1inch-to-aggregators
@itaven itaven merged commit 538fc50 into develop Feb 20, 2024
6 checks passed
@itaven itaven deleted the feature/si-1228-return-1inch-to-aggregators branch February 20, 2024 15:36
@itaven itaven mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiRaiks DiRaiks DiRaiks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jeday @DiRaiks @itaven