refactor(deployed-testnet-defaults.json): use null for unspecified

lidofinance · Oct 10, 2023 · 653f78a · 653f78a
1 parent d66db72
commit 653f78a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/SCRATCH_DEPLOY.md b/SCRATCH_DEPLOY.md
@@ -11,7 +11,7 @@ The repo contains bash scripts which allow to deploy the DAO under multiple envi
 - local node (ganache, anvil, hardhat network) - `dao-local-deploy.sh`
 - goerli testnet - `dao-goerli-deploy.sh`
 
-The protocol has a bunch of parameters to configure for the scratch deployment. The default configuration is stored in files `deployed-<deploy env>-defaults.json`, where `<deploy env>` is the target environment. Currently there is single default configuration `deployed-testnet-defaults.json` suitable for testnet deployments. Compared to the mainnet configuration, it has lower vote durations, more frequent oracle report cycles, etc.
+The protocol has a bunch of parameters to configure for the scratch deployment. The default configuration is stored in files `deployed-<deploy env>-defaults.json`, where `<deploy env>` is the target environment. Currently there is single default configuration `deployed-testnet-defaults.json` suitable for testnet deployments. Compared to the mainnet configuration, it has lower vote durations, more frequent oracle report cycles, etc. Part of the parameters require further specification -- they are marked with `null` values.
 During the deployment, the "default" configuration is copied to `deployed-<network name>.json`, where `<network name>` is the name of a network configuration defined in `hardhat.config.js`. The file `deployed-<network name>.json` gets populated with the contract addresses and transaction hashes during the deployment process.
 
 These are the deployment setups, supported currently:

diff --git a/deployed-testnet-defaults.json b/deployed-testnet-defaults.json
@@ -1,7 +1,7 @@
 {
-  "deployer": "",
+  "deployer": null,
   "gateSeal": {
-    "factoryAddress": "",
+    "factoryAddress": null,
     "sealDuration": 518400,
     "expiryTimestamp": 1714521600
   },
@@ -11,8 +11,8 @@
   "chainSpec": {
     "slotsPerEpoch": 32,
     "secondsPerSlot": 12,
-    "genesisTime": 0,
-    "depositContract": ""
+    "genesisTime": null,
+    "depositContract": null
   },
   "daoInitialSettings": {
     "voting": {

diff --git a/scripts/scratch/00-populate-deploy-artifact-from-env.js b/scripts/scratch/00-populate-deploy-artifact-from-env.js
@@ -22,7 +22,7 @@ async function saveDeployParameters({ web3, artifacts }) {
 
   const state = readNetworkState(network.name, netId)
   const ldoHolder = Object.keys(state.vestingParams.holders)[0]
-  const gateSealAddress = (GATE_SEAL_FACTORY === "" || GATE_SEAL_FACTORY === ZERO_ADDRESS)
+  const gateSealAddress = (GATE_SEAL_FACTORY === null || GATE_SEAL_FACTORY === ZERO_ADDRESS)
     ? ZERO_ADDRESS : ''
 
   state.chainId = CHAIN_ID