Upgrade to capacitor 5 #2476
Open
Upgrade to capacitor 5 #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vovagorodok
commented
Jun 8, 2024
Comment on lines
+78
to
+80
| "capacitor-sound-effect": "https://github.com/veloce/capacitor-sound-effect", | ||
| "capacitor-stockfish": "https://github.com/vovagorodok/capacitor-stockfish", | ||
| "capacitor-stockfish-variants": "https://github.com/vovagorodok/capacitor-stockfish-variants", |
There was a problem hiding this comment.
This capacitors are upgraded and wait for release:
capacitor-sound-effectalready upgraded and wait for release: Can you publish a version that supports capicitor 5? veloce/capacitor-sound-effect#15capacitor-stockfishalready upgraded and wait for release: Migrate Capacitor to 5 veloce/capacitor-stockfish#11capacitor-stockfish-variantswait for merge upgrade and release: Migrate Capacitor to 5 veloce/capacitor-stockfish-variants#1
vovagorodok
commented
Jun 8, 2024
| @@ -100,7 +100,7 @@ function createStylesheetRule( | |||
| styleEl.type = 'text/css' | |||
| document.head.appendChild(styleEl) | |||
| } | |||
| const cleanData = data.replace(/\n/g, '') // FIXME should be fixed in capacitor | |||
| const cleanData = data // FIXME should be fixed in capacitor | |||
|
@veloce all upgrades to capacitor 5 are ready and only wait for release. App works fine. Should we upgrade or leave it on the fork? |
|
@vovagorodok awesome work, but I think we will not merge it as the app is being rewritten in Flutter. Feel free to leave this in the fork. |
|
Understand, better to concentrate fores on new app. I will leave this in the fork ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to release
blichesson Google Play, upgrade tocapacitor 5is needed.I know that
lichobileis unmaintained now, but was decided to ask.Should we:
lichobileand merge this PR (without release on Google Play)?blichessfork?Any decision OK for me