Fix mithril DOMException when reordering gamecards #2396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes dom exception when mithril tries to reorder the game cards after they are wrapped by Siema's slider frames
steps to reproduce (landscape orientation only, there may be other ways):
DOMException: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node
mithril tries to move the second game to the front after the session is refreshed, but can't because the game cards have been wrapped in slider divs by siema
this is fixed by creating the wrapper divs from mithril, and only let siema do the styling
there may be other (better?) ways, but this seemed least intrusive to me