-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to get attachment name #69
base: main
Are you sure you want to change the base?
Conversation
@sunu thanks for PR I'll have a look as soon as time permits. |
Is anyone going to follow up on this and complete it? |
when time permits, just FYI this is not a project with a vast amount of engineering resources. |
Understood. The test failure looked like a minor issue in the MacOS build and not a functional issue, but Im not sure how to address it or I'd try to help out. |
sunu -- thanks for the patch, it solved my problem with reading the attachment names. Tested it (including the Python bindings), and it worked flawlessly (on Linux). I'll try to see if I can fix the test issue with OSX later. |
akappner-- Can you explain where name of any attachment is stored and how to reach it ? |
I have tested this branch and it works successfully on Linux (Fedora + Debian). |
770f29c
to
4f72859
Compare
Hi @joachimmetz ,
I have added a method/property to get the name of attachments. It's mostly mirroring how getting names work on folder objects. It would be amazing if you could take a look and let me know if it looks alright.
Thanks.