Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to get attachment name #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sunu
Copy link

@sunu sunu commented Sep 13, 2018

Hi @joachimmetz ,

I have added a method/property to get the name of attachments. It's mostly mirroring how getting names work on folder objects. It would be amazing if you could take a look and let me know if it looks alright.

Thanks.

@joachimmetz
Copy link
Member

@sunu thanks for PR I'll have a look as soon as time permits.

@wyllys66
Copy link

Is anyone going to follow up on this and complete it?

@joachimmetz
Copy link
Member

when time permits, just FYI this is not a project with a vast amount of engineering resources.

@wyllys66
Copy link

Understood. The test failure looked like a minor issue in the MacOS build and not a functional issue, but Im not sure how to address it or I'd try to help out.

@akappner
Copy link

akappner commented Oct 6, 2019

sunu -- thanks for the patch, it solved my problem with reading the attachment names. Tested it (including the Python bindings), and it worked flawlessly (on Linux). I'll try to see if I can fix the test issue with OSX later.

@apdullahyayik
Copy link

akappner-- Can you explain where name of any attachment is stored and how to reach it ?

@tbfs-account
Copy link

I have tested this branch and it works successfully on Linux (Fedora + Debian).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants