This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
do PRAGMA integrity_check after db restore
#751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
suggested changes
Oct 9, 2023
bottomless-cli/src/main.rs
Outdated
| @@ -205,6 +209,14 @@ async fn run() -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn verify_db(path: &PathBuf) -> Result<String> { | |||
There was a problem hiding this comment.
you should verify the result returned by the pragma here, and return a Result<()> instead
There was a problem hiding this comment.
oh right, thats a good idea :)
I have updated it. Is there any better alternative to anyhow, since we plan to remove it
There was a problem hiding this comment.
I think it can stay inside of bottomless bin, but the alternative to anyhow is to have our own Error enum, and categorize everything manually :)
|
One small thing, and also you need to run rust-fmt :) |
avinassh
force-pushed
the
verify-restore
branch
from
8c8590b to
522d257
Compare
MarinPostma
reviewed
Oct 9, 2023
| if result == "ok" { | ||
| Ok(()) | ||
| } else { | ||
| Err(anyhow::anyhow!(result.to_string())) |
There was a problem hiding this comment.
Suggested change
| Err(anyhow::anyhow!(result.to_string())) | |
| anyhow::bail!("{result}") |
MarinPostma
approved these changes
Oct 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to
verifycommand (#744), after the DB is restored it will do an integrity check. Unlike verify, if the pragma check fails, this keeps the db file around so that we can inspect/analyse it