Wayland message box: improve zenity argument handling #11408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no extra buttons are passed to zenity with `--question --switch` arguments it fails to show anything, however, SDL3 still reports success. To handle this case, we pass an additional "OK" button.
The double quotes were passed literally to the zenity arguments which resulted in the message box displaying literal `""` when no text was given. The empty string is more logical in this case, e.g., the empty title results in the message box having lesser height.
marcin-serwin
force-pushed
the
wayland-message-box
branch
from
ccccb3c
to
65c7d16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When no extra buttons are passed to zenity with
--question --switcharguments it fails to show anything, however, SDL3 still reports
success. To handle this case, we pass an additional "OK" button.
The double quotes were passed literally to the zenity arguments which
resulted in the message box displaying literal
""when no text wasgiven. The empty string is more logical in this case, e.g., the empty
title results in the message box having lesser height.
Existing Issue(s)