streamline cursor clipping logic on windows #11237
Open
+144
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expikr
changed the title
sezero
reviewed
Oct 19, 2024
expikr
changed the title
expikr
changed the title
sezero
reviewed
Oct 19, 2024
slouken
reviewed
Oct 20, 2024
expikr
force-pushed
the
patch-2
branch
4 times, most recently
from
2c8c77b
to
e494782
Compare
expikr
changed the title
expikr
force-pushed
the
patch-2
branch
9 times, most recently
from
785d0ac
to
2414ed9
Compare
expikr
commented
Nov 23, 2024
Comment on lines
+1576
to
+1580
| // This is verbatim translation of the old logic, | ||
| // but I don't quite get what it's trying to do. | ||
| // A clean-room implementation according to MSDN | ||
| // documentation of GetClipCursor is provided in | ||
| // a commented-out block below. |
There was a problem hiding this comment.
I've traced the origin of this logic to this commit:
e56f05b#diff-f2ae5c36a8afc0a9a343a6664ab306da2963213e180af8cd97b12397dcbb9ae7R1572
but still couldn't quite reason about what condition it's trying to check exactly, if @slouken could clarify then that would be extremely helpful.
expikr
force-pushed
the
patch-2
branch
3 times, most recently
from
c66107c
to
0fbe530
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7890
This commit does the following:
relative_mouse_centerfield from Windows-specific per-windowSDL_WindowDatato the globalSDL_Mousestruct, and the corresponding hint callbacks toSDL_mouse.cinstead ofSDL_windowswindow.cSDL_HINT_MOUSE_RELATIVE_CLIP_INTERVALhint, instead solve the root issue with Window Procedure based approachWM_MOUSEMOVEcase of the Window to conditionally callWIN_UpdateClipCursorupon receiving cursor motion if SDL is expecting the mouse to be clipped in some way.WIN_UpdateClipCursorfor better readability of each branch, and avoid calling the Platform API until it is absolutely necessary.relevant commits:
e56f05b (apr 2024)
6c96217 (mar 2024)
ab5351f (mar 2024)
50203d5 (dec 2020)
44f50c6 (jun 2020)
55b24b9 (sep 2018)