Honor the LIBRETRO_DATABASE_DIRECTORY environment variable. #17431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding the C89 CI error - Line 6335 in 64d21b8 you might have to put this before the string concatenation where it fails so that _len doesn't become too big |
zoltanvb
reviewed
Jan 18, 2025
The change caused the 'libretro_directory' config option to always revert to the default value, which was not intended behavior. Reported-by: Michael Cook
This is a follow-up to commit 69ceb95. * frontend/drivers/platform_unix.c (libretro_database_directory): New variable. (frontend_unix_get_env): Set DEFAULT_DIR_DATABASE to the value of the LIBRETRO_DATABASE_DIRECTORY environment variable, if available. * frontend/drivers/platform_win32.c: Likewise. * configuration.c (config_load_file) <libretro_database_directory>: New variable. Use the values of the LIBRETRO_DATABASE_DIRECTORY environment variables instead of their corresponding configured values, when set. * docs/retroarch.6: Document. * retroarch.c (retroarch_print_help): List supported environment variables, and cross-reference the man page.
Apteryks
force-pushed
the
add-libretro-database-env-var
branch
from
57a6451 to
2d97c97
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to commit 69ceb95 (from #17054)
Reviewers
@JesseTG