Minor fixes to udev input drivers. Add support for canary builds to lakka updater stuff #15818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is handy with controllers like the Nintendo Joycons that have a daemon app in the background to handle combining them into one controller(Joycond) Since the device was already added, but joycond clamped permissions on evdev retroarch was never updating the controller input change, this fixes that issue. Note: Needs a patch in joycond as well, to send change uevent. This shouldnt cause any issues with other controllers, as the kernel probably will never send change events for these device types.
GavinDarkglider
changed the title
JoeOsborn
pushed a commit
to JoeOsborn/RetroArch
that referenced
this pull request
Nov 2, 2023
…akka updater stuff (libretro#15818) * Input: Udev: Fix touch support building against older kernel headers * Input: Udev: Fix Touch Deep Debug compile issues * Input: Joypad: Udev: Joypad: Add Change detection for udev events This is handy with controllers like the Nintendo Joycons that have a daemon app in the background to handle combining them into one controller(Joycond) Since the device was already added, but joycond clamped permissions on evdev retroarch was never updating the controller input change, this fixes that issue. Note: Needs a patch in joycond as well, to send change uevent. This shouldnt cause any issues with other controllers, as the kernel probably will never send change events for these device types. * Lakka: Add canary builds to updater
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
…akka updater stuff (libretro#15818) * Input: Udev: Fix touch support building against older kernel headers * Input: Udev: Fix Touch Deep Debug compile issues * Input: Joypad: Udev: Joypad: Add Change detection for udev events This is handy with controllers like the Nintendo Joycons that have a daemon app in the background to handle combining them into one controller(Joycond) Since the device was already added, but joycond clamped permissions on evdev retroarch was never updating the controller input change, this fixes that issue. Note: Needs a patch in joycond as well, to send change uevent. This shouldnt cause any issues with other controllers, as the kernel probably will never send change events for these device types. * Lakka: Add canary builds to updater
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does 3 things.
#1 Fixes building gated udev touch support against < 4.16 version of kernel.
#2 Fixes macros for Deep Debug included with the multitouch support, so now it can be compiled.
#3 Adds change event detection to polling in udev_joypad, which basically removes, then adds the controller again, if a change uevent comes in. This is done for controllers like the nintendo joycons that use a userspace app, and permission clamping to prevent single joycon mode to show up in apps, when set up in the combined mode. This allows Joycond(Userspace app) or any other userspace controller app that creates an event for a controller to issue change events as needed, and have retroarch re-detect/setup the controller.