Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mac mismatch block #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix mac mismatch block #9

wants to merge 1 commit into from

Conversation

ViRb3
Copy link
Contributor

@ViRb3 ViRb3 commented Nov 14, 2018

I'm not sure if this is a proper fix, but it passes along an error that is otherwise ignored, resulting in a block.

@ViRb3
Copy link
Contributor Author

ViRb3 commented Nov 14, 2018

Just reproduced the error, but unfortunately it still blocks:

2018/11/14 18:01:05 received mac doesn't match
Unknown channel!
2018/11/14 18:01:05 received mac doesn't match
Unhandled cmd 0xdc
2018/11/14 18:01:05 received mac doesn't match
Unhandled cmd 0x3c

@ViRb3
Copy link
Contributor Author

ViRb3 commented Dec 24, 2018

I think I narrowed down the issue - it seems that whenever I use the official Spotify on my PC, it 'invalidates' the session used by librespot, which causes the mac mismatch (although with a substantial delay). I tried shutting down all other Spotify clients and running libespot by itself for a full night, no problems.

@xplodwild
Copy link
Contributor

This is a good idea, however the error returned should be handled by the parent function and close/restart the connection accordingly. I'm not sure reconnection is properly supported yet, so this is on hold

@ViRb3
Copy link
Contributor Author

ViRb3 commented Feb 26, 2019

Indeed, I attempted a reconnect on error, but it seems like the function is not working properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants