fix(webrtc): Don't emit addresses from other interfaces #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rkuhn
approved these changes
Nov 18, 2022
| let if_watcher = match self.if_watcher.as_mut() { | ||
| Some(w) => w, | ||
| None => return Poll::Pending, | ||
| }; |
There was a problem hiding this comment.
once we move to Rust 1.65 this can become nicer :-)
let Some(if_watcher) = self.if_watcher.as_mut() else { return Poll::Pending };There was a problem hiding this comment.
Yep, looking forward to this, I just didn't want to bump it yet. At least not until we have #3090 where we will start to properly verify our MSRV.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we would always run
IfWatcher, even if we were only listening on a specific interface. This patch fixes this behaviour and aligns it with howlibp2p-quicoperates.Notes
cc @melekes
Links to any relevant issues
Open Questions
Change checklist