Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/release: Document cargo-release process and mention root changelog #3028

Merged
merged 3 commits into from
Oct 20, 2022
Merged

docs/release: Document cargo-release process and mention root changelog #3028

merged 3 commits into from
Oct 20, 2022

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Oct 14, 2022

Description

  • c55edf2 cargo-release mxinden/cargo-release docs/release: Document update to root level changelog.md
  • 4ac0c45 docs/release: Document cargo-release process

Using cargo release worked like a charm for #2931.

Links to any relevant issues

See discussion in #2902.

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mxinden mxinden mentioned this pull request Oct 14, 2022
Closed
thomaseizinger
thomaseizinger approved these changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting this!

I strongly vote for codifying this ASAP as part of a workflow.

@mxinden
Copy link
Member Author

mxinden commented Oct 20, 2022

Merging here. Semver check failure is discussed in #2647, Testground failure is tracked in libp2p/test-plans#59.

@mxinden mxinden merged commit cec1a8d into libp2p:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxinden @jxs @thomaseizinger