Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swarm: Fix rare test failure of multiple_addresses_err #2882

Merged
merged 6 commits into from
Sep 11, 2022

Commits on Sep 9, 2022

  1. Configuration menu
    Copy the full SHA
    374b50a View commit details
    Browse the repository at this point in the history
  2. Use HashSet to avoid rare test failure

    In case we accidentally generate the same port twice, we will try to
    issue two dial attempts to the same address but also expect two dial
    errors which is exactly what this test is trying to catch.
    Unfortunately, the assertion is badly written and does not catch
    duplicate inputs.
    thomaseizinger committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    ccd33d7 View commit details
    Browse the repository at this point in the history
  3. Swap expected and failed values in assertion

    Not sure if it is just me, but I'd expect the expectation to come first.
    thomaseizinger committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    aedd5c7 View commit details
    Browse the repository at this point in the history
  4. Unroll loops

    thomaseizinger committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    0d42c0a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4f9d839 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2022

  1. Configuration menu
    Copy the full SHA
    21cab35 View commit details
    Browse the repository at this point in the history