Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use isPrivate to detect private multiaddrs #2868

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Conversation

achingbrain
Copy link
Member

To prevent throwing when non-thin waist addresses are encountered, use isPrivate instead of converting the multiaddr to a node address.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

To prevent throwing when non-thin waist addresses are encountered,
use `isPrivate` instead of converting the multiaddr to a node address.
@achingbrain achingbrain requested a review from a team as a code owner November 30, 2024 13:49
@achingbrain achingbrain merged commit 2c182d2 into main Nov 30, 2024
32 of 34 checks passed
@achingbrain achingbrain deleted the fix/use-is-private branch November 30, 2024 15:15
acul71 pushed a commit to acul71/js-libp2p-fork that referenced this pull request Dec 1, 2024
To prevent throwing when non-thin waist addresses are encountered,
use `isPrivate` instead of converting the multiaddr to a node address.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant