Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add retries to certificate provisioning #2841

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

achingbrain
Copy link
Member

The p2p-forge service at libp2p.direct sometimes rejects requests with 401 errors, the only thing to do is to retry.

This can probably be reverted in future if it becomes clear why some requests are rejected.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

The p2p-forge service at libp2p.direct sometimes rejects requests
with 401 errors, the only thing to do is to retry.

This can probably be reverted in future if it becomes clear why
some requests are rejected.
@achingbrain achingbrain requested a review from a team as a code owner November 25, 2024 08:03
@achingbrain achingbrain merged commit 98b4304 into main Nov 25, 2024
33 of 34 checks passed
@achingbrain achingbrain deleted the fix/add-retries-to-provisioning branch November 25, 2024 08:59
acul71 pushed a commit to acul71/js-libp2p-fork that referenced this pull request Dec 1, 2024
The p2p-forge service at libp2p.direct sometimes rejects requests
with 401 errors, the only thing to do is to retry.

This can probably be reverted in future if it becomes clear why
some requests are rejected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant