Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow adding external ip/port mapping #2836

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

achingbrain
Copy link
Member

Adds functions to the address manager to add external ip/port/protocol tuples which will be added as extra addresses to the list of multiaddrs the node is listening on.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Adds functions to the address manager to add external ip/port/protocol
tuples which will be added as extra addresses to the list of multiaddrs
the node is listening on.
@achingbrain achingbrain requested a review from a team as a code owner November 21, 2024 17:22
@achingbrain achingbrain merged commit 6ddc1b8 into main Nov 22, 2024
33 of 34 checks passed
@achingbrain achingbrain deleted the feat/add-external-ip-port-mapping branch November 22, 2024 12:26
acul71 pushed a commit to acul71/js-libp2p-fork that referenced this pull request Dec 1, 2024
Adds functions to the address manager to add external ip/port/protocol
tuples which will be added as extra addresses to the list of multiaddrs
the node is listening on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant