feat: add auto-tls service #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an optional service that requests a Let's Encrypt-style TLS certificate when publicly dialable addresses are detected. This will allow transports such as WebSockets to upgrade themselves to be the secure version.
3 tasks
achingbrain
commented
Nov 4, 2024
2color
reviewed
Nov 4, 2024
2color
reviewed
Nov 4, 2024
2color
reviewed
Nov 4, 2024
achingbrain
commented
Nov 5, 2024
SgtPooki
reviewed
Nov 12, 2024
packages/auto-tls/src/index.ts
Outdated
Comment on lines
112
to
117
| /** | ||
| * How long before the expiry of the certificate to renew it in ms | ||
| * | ||
| * @default 60000 | ||
| */ | ||
| renewThreshold?: number |
There was a problem hiding this comment.
This situation is a little different than domain cert renewal, but cert renewal should allow for resolving any errors that pop up when a renewal is attempted. Should we set the renewal time to a full day or week before expiry instead of only one minute?
There was a problem hiding this comment.
I've increased the default to one day but I'm not sure what we can do here other than retry?
|
Merging to make landing #2800 easier |
SgtPooki
reviewed
Nov 19, 2024
Comment on lines
+88
to
+94
| ## Browser `<script>` tag | ||
|
|
||
| Loading this module through a script tag will make it's exports available as `Libp2pPlaintext` in the global namespace. | ||
|
|
||
| ```html | ||
| <script src="https://unpkg.com/@libp2p/plaintext/dist/index.min.js"></script> | ||
| ``` |
There was a problem hiding this comment.
Suggested change
| ## Browser `<script>` tag | |
| Loading this module through a script tag will make it's exports available as `Libp2pPlaintext` in the global namespace. | |
| ```html | |
| <script src="https://unpkg.com/@libp2p/plaintext/dist/index.min.js"></script> | |
| ``` |
Remove browser script tag in docs because it throws in browser?
There was a problem hiding this comment.
Shouldn't be Libp2pPlaintext anyway..
acul71
pushed a commit
to acul71/js-libp2p-fork
that referenced
this pull request
Dec 1, 2024
Adds an optional service that requests a Let's Encrypt-style TLS certificate when publicly dialable addresses are detected. This will allow transports such as WebSockets to upgrade themselves to be the secure version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional service that requests a Let's Encrypt-style TLS certificate when publicly dialable addresses are detected.
This will allow transports such as WebSockets to upgrade themselves to be the secure version.
Change checklist