Logrus rename #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 7, 2018 16:37
Signed-off-by: Harsh Desai <[email protected]>
Signed-off-by: Harsh Desai <[email protected]> Signed-off-by: Luis Pabón <[email protected]>
adityadani
approved these changes
Mar 14, 2018
There was a problem hiding this comment.
lgtm
Ideally I will love to remove the vendor'ed directory in this package. gossip should be treated like a library and should not have its own vendor'ed directory. We can add a new issue in this repo to remove the vendor'ed directory and fix the travis builds to pull the latest dependent packages and then run the tests.
@lpabon What do you think?
|
Sounds good @adityadani |
|
Created #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.