-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: Redesign Liberapay #935
base: master
Are you sure you want to change the base?
Conversation
do you have a before / after image to illustrate the changes? |
@Changaco, when you find time, could you please take a look at the changes I made here? Is there anything you would like me to add or change? |
I'm not convinced by some of the proposed changes.
But maybe that's just me. Can we get other opinions? Also:
|
Just to add my thoughts too, a lot of the changes seem totally unnecessary. Like the navbar, removing the colour? Why? It needs to stand out, it's a navbar. |
I don't understand much about design, but I recall @onpon4 didn't like the yellow color at all from a forum discussion, here the reasoning:
|
@jorgesumle, that is my opinion on the yellow too. I don't plan on leaving the navbar like this, but I really dislike the current yellow colour on liberapay.com. I will mark this PR as a [WIP] to make it clear to all of you that I am still working on this and by no means done. |
There are no less than 4 buttons to create an account here. I think one is enough. Any amount of design will not overcome the busy look of too much text, which is an improvement directly related to induced stress for the user. I can't seem to overstate this enough. "Sponsors" and "Thanks" naturally belong at the bottom because it is where one would expect to find them. I liked the yellow top bars. |
I personnally prefer this new UI to the current one. Is it still goind on? I collected the following proposition from the comment:
|
@@ -70,27 +70,39 @@ recent = query_cache.one(""" | |||
|
|||
<div class="jumbotron section"> | |||
<p><img src="{{ website.asset('liberapay/icon-v2_yellow-r.svg') }}" height=100 width=100 /></p> | |||
<p>{{ _("Liberapay is a recurrent donations platform.") }}</p> | |||
<p>{{ _("We help you fund the creators and projects you appreciate.") }}</p> | |||
<h2>{{ _("Liberapay is a recurrent donations platform") }}</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<h2>{{ _("Liberapay is a recurrent donations platform") }}</h2> | |
<h2>{{ _("Liberapay is a recurrent donation platform") }}</h2> |
Could we add AccessLint so that our accessibility is constantly reviewed? Especially for this redesign? The best thing would be to use semantic HTML but the latest Bootstrap has accessibility considerations built in, I think. |
I have enabled AccessLint for this repository. |
This is a PR for #734. My goal is to make Liberapay look less like bootstrapy and more unique, and appealing to its users.